Upgrade to testthat 3rd edition#22
Merged
Merged
Conversation
Damonamajor
commented
Apr 27, 2026
| scales, | ||
| snakecase, | ||
| testthat (>= 2.1.0), | ||
| testthat (>= 3.0.0), |
Contributor
Author
There was a problem hiding this comment.
Don't know if you have a preference for this update version.
Member
There was a problem hiding this comment.
[Praise] Nope, this looks great!
jeancochrane
requested changes
Apr 28, 2026
Member
jeancochrane
left a comment
jeancochrane
left a comment
There was a problem hiding this comment.
Thanks, this looks great! Before we merge, do you mind resolving the warnings that testthat is printing to the console? Let me know if you get stuck and I'm happy to help out.
| scales, | ||
| snakecase, | ||
| testthat (>= 2.1.0), | ||
| testthat (>= 3.0.0), |
Member
There was a problem hiding this comment.
[Praise] Nope, this looks great!
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on ccao-data/ccao#51 to update testthat to version 3. Also removes context since that got deprecated.